Skip to content

Fix Daubechies derivative scaling and complete coverage - #1455

Merged
NAThompson merged 1 commit into
developfrom
fix/daubechies-1101
Sep 5, 2026
Merged

Fix Daubechies derivative scaling and complete coverage#1455
NAThompson merged 1 commit into
developfrom
fix/daubechies-1101

Conversation

@NAThompson

Copy link
Copy Markdown
Collaborator

Exercise explicit refinements, absolute-error mode, interior derivatives, and the Haar wavelet. Remove obsolete interpolators and migrate the remaining example to matched_holder_aos.

Correct missing grid-spacing factors in cardinal quintic and septic derivatives, including septic node evaluation. Add cubic-polynomial regressions for both data layouts and non-unit grid spacing.

Fixes #1101

Exercise explicit refinements, absolute-error mode, interior derivatives, and the Haar wavelet. Remove obsolete interpolators and migrate the remaining example to matched_holder_aos.

Correct missing grid-spacing factors in cardinal quintic and septic derivatives, including septic node evaluation. Add cubic-polynomial regressions for both data layouts and non-unit grid spacing.

Fixes #1101
@NAThompson

Copy link
Copy Markdown
Collaborator Author

@mborland : Would you mind spending a few of you claude credits reviewing this?

It appears I had missed some major scale factors here.

@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.42%. Comparing base (c6d79d9) to head (9a43658).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #1455    +/-   ##
=========================================
  Coverage    95.41%   95.42%            
=========================================
  Files          831      831            
  Lines        69588    69693   +105     
=========================================
+ Hits         66400    66506   +106     
+ Misses        3188     3187     -1     
Files with missing lines Coverage Δ
...th/interpolators/detail/quintic_hermite_detail.hpp 80.80% <100.00%> (ø)
...ath/interpolators/detail/septic_hermite_detail.hpp 85.31% <100.00%> (ø)
...oost/math/special_functions/daubechies_scaling.hpp 100.00% <ø> (ø)
test/daubechies_scaling_test.cpp 95.50% <100.00%> (+0.38%) ⬆️
test/daubechies_wavelet_test.cpp 95.19% <100.00%> (+2.43%) ⬆️
test/quintic_hermite_test.cpp 100.00% <100.00%> (ø)
test/septic_hermite_test.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d79d9...9a43658. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland

mborland commented Sep 5, 2026

Copy link
Copy Markdown
Member

@mborland : Would you mind spending a few of you claude credits reviewing this?

It appears I had missed some major scale factors here.

Seems like it's good:

image

@NAThompson

Copy link
Copy Markdown
Collaborator Author

Build failure is this:

 The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 2C277A0A352154E5 NO_PUBKEY 1E9377A2BA9EF27F
Reading package lists...
W: GPG error: https://ppa.launchpadcontent.net/ubuntu-toolchain-r/test/ubuntu jammy InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 2C277A0A352154E5 NO_PUBKEY 1E9377A2BA9EF27F
E: The repository 'https://ppa.launchpadcontent.net/ubuntu-toolchain-r/test/ubuntu jammy InRelease' is not signed.
Error: Process completed with exit code 100.

@NAThompson
NAThompson merged commit 5a6c106 into develop Sep 5, 2026
86 of 88 checks passed
@NAThompson
NAThompson deleted the fix/daubechies-1101 branch September 5, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Untested and dead code in daubechies_scaling.hpp

2 participants