Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #665 +/- ##
==========================================
- Coverage 59.75% 59.57% -0.18%
==========================================
Files 98 98
Lines 10274 10311 +37
Branches 1482 1499 +17
==========================================
+ Hits 6139 6143 +4
- Misses 3488 3507 +19
- Partials 647 661 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adjust the neutral_mixed model to run in Fci.
Change Summary
Validation
One 2D MMS test that tests density and pressure diffusion and conduction. More tests soon (1D).
AI Assistance
None
Documentation
Some comments in the code
Review Notes
Generally, the code seems quite consistent. At some places, we apply BCs after calculating quantities from fields that we also set BCs for, which might introduce inconsistencies. Something like
logPnlim = log(Pnlim); logPnlim.applyBoundary();This might make sense physics-wise, but obviously kills MMS tests as these destroy the error convergence. @mikekryjak Is there a reason why we e.g. set these BCs for certain variables specifically?