Skip to content

atlas: frontend code - #13676

Merged
vadimberezniker merged 2 commits into
masterfrom
bb-atlas-app
Oct 5, 2026
Merged

vadimberezniker merged 2 commits into
masterfrom
bb-atlas-app

Conversation

@vadimberezniker

Copy link
Copy Markdown
Member

For the general setup I tried to mimmick what we do for the apps.

Some CSS and components from the app are reused (should we move them to a more general location?)

For the general setup I tried to mimmick what we do for the apps.

Some CSS and components from the app are reused (should we move them to
a more general location?)

@buildbuddy-io buildbuddy-io Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds the frontend for the Atlas app (enterprise/atlas/app/) and its serving code under enterprise/atlas/cmd/atlas/. The PR diff couldn't be fetched, so these comments come from reading the full files on the bb-atlas-app branch and may point at code this PR didn't change.

Comment thread enterprise/atlas/app/root/root.tsx
Comment thread enterprise/atlas/app/object/object.tsx
Comment thread enterprise/atlas/app/lib/theme.ts
Comment thread enterprise/atlas/app/lib/router.ts
Comment thread enterprise/atlas/app/object/object.tsx
@jdhollen
jdhollen self-requested a review October 5, 2026 21:58
.atlas-port-chip {
display: inline-flex;
align-items: stretch;
font-size: 11.5px;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me, i'd like for all of these to be whole pixel values (there are about 10 of them). but it might open a whole can of worms with jitter on the page. i'd just take that as a sign that there would probably be jitter on someone else's page with a different pixel density.

@vadimberezniker
vadimberezniker merged commit 0a69eb5 into master Oct 5, 2026
23 checks passed
@vadimberezniker
vadimberezniker deleted the bb-atlas-app branch October 5, 2026 23:00
vadimberezniker added a commit that referenced this pull request Oct 6, 2026
For the general setup I tried to mimmick what we do for the apps.

Some CSS and components from the app are reused (should we move them to
a more general location?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants