Repository navigation
data: preserve CCD fallback after failed conformer embedding - #350
Closed
mjslee0921 wants to merge 1 commit into
Closed
mjslee0921 wants to merge 1 commit into
mjslee0921 wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKit
EmbedMoleculecan return-1when embedding fails without raising an exception. The CCD cache generator currently treats that return as success: it changes the selected conformer ID to-1, labels itrdkit, and sets every reference-coordinate mask entry to true. This can mark missing Ideal coordinates as valid.Preserve the initialized Ideal conformer ID, type, and per-atom mask when the returned ID is negative. Successful embeddings still select the newly generated conformer and its all-valid mask; the existing exception fallback is unchanged.
Regression tests exercise the actual RDKit failure sentinel using inconsistent distance bounds, both partial and entirely missing Ideal coordinates, actual successful conformer generation, and the exception path. They check selected metadata, unchanged existing conformers, and atom-name mapping.
Validation: all four focused tests pass. Scoped repository hooks pass after adding the required license header.