Repository navigation
data: avoid reconstructing replaced oxygen branches - #352
Closed
mjslee0921 wants to merge 1 commit into
Closed
mjslee0921 wants to merge 1 commit into
mjslee0921 wants to merge 1 commit into
Conversation
|
Michael Lee seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A deposited covalent bond at an oxygen can replace an entire unobserved CCD branch. The existing non-CCD reconstruction fallback only considers immediate terminal neighbors, so it regenerates a missing phosphate at an already bonded nucleotide O5′.
Extend that fallback with a conservative heavy-atom graph check: neutral oxygen, two CCD single bonds, one retained external single bond to a nonmetal, a unique wholly unobserved acyclic side, and observed support on the retained connected side. Equivalent observed copies must agree; any deposited branch atom in the entity site vetoes removal. Protection concerns retained raw atoms and bonds, not unrepresented struct_conn declarations. Existing terminal-neighbor behavior remains unchanged. Native confidence slots already use canonical atom-name indices.
Validation: 16 focused tests and scoped hooks passed. Actual same-input 4N48 reconstruction removes only P/OP1/OP2/OP3 from G1 in chains C and D, preserving every surviving atom annotation, coordinate and bond; named confidence slots are unchanged. The 237,550-atom 6D9J reconstruction is unchanged. These controls cover reconstruction before assembly/cropping; revised full-panel and final-consumer validation remain outstanding.