Repository navigation
fix(anta.tests): Preserve SA178 hotfix mitigation evidence - #5
Merged
gmuloc merged 2 commits intoOct 30, 2026
Conversation
gmuloc
merged commit Oct 30, 2026
c80df5e
into
carl-baillargeon:fix/sa178-snmp-remote-users
15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When SA178 finds encrypted SNMPv3 credentials on an affected release with its applicable persistent SWIX hotfix, report Mitigated instead of Not Affected. Retain the hotfix as mitigation evidence and the encrypted credential syntax as supporting context, and provide fixed-release guidance. ANTA still reports Success.
This PR targets the branch behind aristanetworks#1856.
Allow
MitigatedResult.contextto carry existing finding evidence. Keep the shared projector unchanged. Preserve the general encrypted-credentials fallback, immediate Not Affected results for absent prerequisites, and existing legacy-credential remediation. Consolidate the legacy result construction without return-count lint suppressions.An effective applicable hotfix must be boot-persistent and match one of the exact eligible releases. Encrypted inputs without a confirmed applicable effective hotfix retain the existing fallback; the table does not assert that EOS normally produces those combinations. Otherwise, unavailable facts required to decide exposure produce Error.
Validation: