fix: encode sACN discovery universes in network order - #152
Open
iibaranov-IG wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #142.
The discovery PDU copied
uint16_tbytes directly from an array ofsacn_output_universestructures. Besides retaining host byte order, this reads later values with the wrong stride because each source entry contains timestamp and mark fields.This serializes each universe field individually with
htobe16. The new native regression uses universes 1, 256, and0x1234and checks the exact payload bytes00 01 01 00 12 34, covering both byte order and structure stride.Validation:
make testpasses on macOS;The complete optional-backend build was not run because the local host lacks Lua development headers; the sACN backend itself builds successfully.