Skip to content

ci: allow Dependabot to authenticate ECR Public pulls #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdalvaro merged 1 commit into from
Oct 30, 2026
Merged

ci: allow Dependabot to authenticate ECR Public pulls #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,14 @@ jobs:
driver-opts: network=host

- name: Configure read-only AWS credentials
if: github.actor != 'dependabot[bot]' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
uses: aws-actions/configure-aws-credentials@v6.3.0
with:
role-to-assume: ${{ vars.AWS_ECR_READ_ONLY_ROLE_ARN }}
aws-region: us-east-1

- name: Login to Amazon ECR Public
if: github.actor != 'dependabot[bot]' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
uses: aws-actions/amazon-ecr-login@v2.1.7
with:
registry-type: public
Expand Down Expand Up @@ -173,14 +173,14 @@ jobs:
persist-credentials: false

- name: Configure read-only AWS credentials
if: github.actor != 'dependabot[bot]' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
uses: aws-actions/configure-aws-credentials@v6.3.0
with:
role-to-assume: ${{ vars.AWS_ECR_READ_ONLY_ROLE_ARN }}
aws-region: us-east-1

- name: Login to Amazon ECR Public
if: github.actor != 'dependabot[bot]' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
uses: aws-actions/amazon-ecr-login@v2.1.7
with:
registry-type: public
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/security-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,14 @@ jobs:
uses: docker/setup-buildx-action@v4.4.1

- name: Configure read-only AWS credentials
if: github.actor != 'dependabot[bot]' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
uses: aws-actions/configure-aws-credentials@v6.3.0
with:
role-to-assume: ${{ vars.AWS_ECR_READ_ONLY_ROLE_ARN }}
aws-region: us-east-1

- name: Login to Amazon ECR Public
if: github.actor != 'dependabot[bot]' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
uses: aws-actions/amazon-ecr-login@v2.1.7
with:
registry-type: public
Expand Down
5 changes: 1 addition & 4 deletions tests/test_ecr_login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@
import unittest

ROOT = pathlib.Path(__file__).resolve().parents[1]
GUARD = (
"github.actor != 'dependabot[bot]' && "
"(github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)"
)
GUARD = "github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository"


class ECRLoginTests(unittest.TestCase):
Expand Down
Loading