Repository navigation
Remove settings and statistics from server API and NetworkService - #818
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since simulations are serialized into a single sim file, the separate settings and statistics payloads no longer exist. The client still sent empty strings for them and the server still stored them.
Changes
Server (
scripts/Server/main.py)settingsandstatisticscolumns from theSimulationmodel, so new databases no longer create them./uploadsimulationand/replacesimulationno longer read or store those fields.settingswas a required form field before; removing it keeps older clients working, since unknown form fields are ignored anyway./downloadsettingsand/downloadstatisticsendpoints. They had no caller in the client.Client (
source/Network/NetworkService.cpp)uploadResourceandreplaceResource.Tests
/downloadcontentonly.Notes
No database migration is included, as agreed. An existing production database keeps both columns physically, and
settingsisNOT NULLwithout a default there, so inserts from the new code would fail against it. If the live database is kept, it needs:Testing
NetworkTests.exe(4),EngineInterfaceTests.exe(174),PersisterTests.exe(70) all pass.🤖 Generated with Claude Code