Repository navigation
v3.0.1: keep the summary honest, read config from the base branch - #67
Merged
Merged
Conversation
Three ways the review lost or misplaced work between runs: - The last reviewed SHA advanced even when files were skipped, the diff was truncated or the model output was unusable, so the next push diffed past them and they vanished from "Not reviewed". It now advances only after a complete, delivered run. - Findings counted as posted when GitHub rejected the review. They are now listed in the summary and retried on the next push. - After a merge from the base branch or a rebase, the incremental diff held changes outside the pull request and GitHub rejected the review with 422. The comparison is checked first and falls back to a full review, and findings are placed against the pull request's own diff. Also: a finding moved to fit the diff no longer offers its suggestion as a one-click change, since it was written for other lines. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
It was read from the working directory. With a checkout, the pull request controlled it: ignore_paths "**" or max_comments 0 reviews a change out of existence, and base_url sends the API key to another server. Without a checkout, as the README recommends, it was never read at all. It is now fetched over the API at the pull request's base commit, and base_url is an action input only. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
action.yml still called it "ChatGPT GitHub Actions". The migration guide and release notes said @v2 was untouched; it was moved once, to the fix-only v2.1. Changelog entries for everything since v3.0.0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Code review did not runThe model: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes found reviewing v3.0.0 before announcing it. Meant to ship as v3.0.1, together with the
max_tokens8192 default that is onmainbut not in any tag (@v3still runs 2048).Fixed
last_reviewed_shaadvanced even when files were skipped, the diff was truncated, or the model output was unusable. It now advances only after a complete run whose comments were delivered, and the summary says the next push reviews that range again.status != ahead, or a merge commit in the range, falls back to a full review with the reason in the summary). As a second guard, findings are placed against the PR's own diff and files outside it are not sent to the model.relocated=Trueand its suggestion is shown as a plain code block, not as```suggestion.Security
.genai-review.ymlis read from the base commit over the API, not from disk. Before, with a checkout the PR author controlled it (ignore_paths: ["**"],max_comments: 0,base_urlpointing at their own server so it receives the key). Without a checkout, which the README recommends, the file was never read.base_urlis now an action input only.Docs
action.yml: "ChatGPT GitHub Actions" → "GenAI Code Review" (that Marketplace slug is free). The listing itself changes only when a release is published to the Marketplace.@v2was untouched. It points at v2.1; they now say so.Tests
284 pass (was 267), lint clean. New regression tests for each item. The compare fields (
status,total_commits,commits[].parents) were checked against this repository's real API:4dafa5d...a3372f9isaheadwith three 2-parent commits, which is exactly case 3.🤖 Generated with Claude Code