Repository navigation
fix: temporarily disable PostGIS trunk build - #159
Merged
Merged
Conversation
PostGIS periodically fails to build against PostgreSQL trunk (e.g. it hasn't caught up to a new major version yet, or trips on an in-development API change). Because minimal, standard, and postgis are all built by the same `docker buildx bake` invocation, a PostGIS failure currently fails the whole build-pg job -- blocking minimal and standard from being pushed, and preventing the E2E job from running at all. Remove `postgis` from the default bake matrix, and the corresponding tag overrides in build.yml / build-commitfest.yml, until the build is split so that a PostGIS failure can no longer block the rest of the pipeline. The `postgis` Dockerfile stage itself is untouched. Refs #158 Assisted-by: Claude Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
4 of 5 tasks
NiccoloFei
added a commit
that referenced
this pull request
Oct 2, 2026
…peline (#161) PostGIS periodically fails to build against PostgreSQL trunk. Since it was built in the same `docker buildx bake` invocation as `minimal`/`standard`, a PostGIS-only failure took the whole `build-pg` job down with it -- blocking image publishing and, transitively, E2E testing (interim mitigation in #159 disabled PostGIS entirely; this is the long-term fix tracked in #158). - `docker-bake.hcl`: create `"default"` group to build the postgres minimal/standard and keep `postgis` out of the `"default"` group matrix. A plain `docker buildx bake` (or `bake --push`) still only builds minimal/standard; `docker buildx bake postgis` builds it explicitly. - `reusable-build.yml`: generalize the old `minimal_tags`/`standard_tags` inputs into a single `targets` input (one `"<bake target>:<tags>"` entry per line) so the workflow can build an arbitrary set of targets, and pass the parsed target names through to `docker/bake-action`'s `targets` input (it only builds bake's `default` group otherwise). Add a `best_effort` input that sets `continue-on-error` on this workflow's own `build`/`merge` jobs (GitHub Actions doesn't allow `continue-on-error` directly on a job that calls a reusable workflow via `uses:`, so the tolerance has to live inside the reusable workflow itself. - `build.yml`, `build-commitfest.yml`, `continuous-delivery.yml`: add a `build-postgis` job, parallel to and independent of `build-pg`, calling `reusable-build.yml` with `targets: postgis:...` and `best_effort: true`. Nothing depends on `build-postgis`, so a PostGIS failure no longer affects minimal/standard publishing or E2E. - `README.md`: document building the `postgis` target explicitly. - Bump the ubuntu runner for arm to ubuntu-26.04-arm (all other ubuntu runner were already bump to 26.04). Closes #158 --------- Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Tao Li <tao.li@enterprisedb.com> Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Co-authored-by: Tao Li <tao.li@enterprisedb.com> Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postgisfrom the defaultdocker buildx bakematrix, and the corresponding tag overrides inbuild.yml/build-commitfest.yml.minimal/standard, a PostGIS failure was blocking image publishing and E2E testing for the whole pipeline.postgisDockerfile stage itself is untouched — this only stops it being built automatically.Test plan
docker buildx bake --printlocally confirms onlyminimalandstandardtargets remain in the default group.build.ymlandbuild-commitfest.yml.minimal/standardsuccessfully.Assisted-by: Claude