Skip to content

docs: web acl id can be an ARN for newer WAFs #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yangci (oycyc) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: web acl id can be an ARN for newer WAFs #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b10716
docs: web acl id can be an ARN for newer WAFs
oycyc Aug 1, 2025
4d3dd1d
Merge branch 'main' into docs/web_acl_id
kevcube Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ aws acm request-certificate --domain-name example.com --subject-alternative-name
| <a name="input_viewer_minimum_protocol_version"></a> [viewer\_minimum\_protocol\_version](#input\_viewer\_minimum\_protocol\_version) | The minimum version of the SSL protocol that you want CloudFront to use for HTTPS connections. This is ignored if the default CloudFront certificate is used. | `string` | `"TLSv1.2_2021"` | no |
| <a name="input_viewer_mtls_config"></a> [viewer\_mtls\_config](#input\_viewer\_mtls\_config) | Configuration for mutual TLS (mTLS) authentication on the CloudFront distribution. The trust store (`aws_cloudfront_trust_store`) should be managed outside this module, as it is commonly shared across multiple distributions. | <pre>object({<br/> mode = string<br/> trust_store_id = string<br/> advertise_trust_store_ca_names = optional(bool, false)<br/> ignore_certificate_expiry = optional(bool, false)<br/> })</pre> | `null` | no |
| <a name="input_viewer_protocol_policy"></a> [viewer\_protocol\_policy](#input\_viewer\_protocol\_policy) | allow-all, redirect-to-https | `string` | `"redirect-to-https"` | no |
| <a name="input_web_acl_id"></a> [web\_acl\_id](#input\_web\_acl\_id) | ID of the AWS WAF web ACL that is associated with the distribution | `string` | `""` | no |
| <a name="input_web_acl_id"></a> [web\_acl\_id](#input\_web\_acl\_id) | ID or ARN of the AWS WAF web ACL that is associated with the distribution. NOTE: If using the latest version of WAF (WAFv2), be sure to use the ARN. If using WAF Classic, use the ID. https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudfront_distribution#web_acl_id-3 | `string` | `""` | no |

## Outputs

Expand Down Expand Up @@ -326,15 +326,15 @@ Setup dependencies:

To run tests:

- Run all tests:
- Run all tests:
```sh
atmos test run
```
- Clean up test artifacts:
- Clean up test artifacts:
```sh
atmos test clean
```
- Explore additional test options:
- Explore additional test options:
```sh
atmos test --help
```
Expand Down
2 changes: 1 addition & 1 deletion variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ variable "custom_header" {

variable "web_acl_id" {
type = string
description = "ID of the AWS WAF web ACL that is associated with the distribution"
description = "ID or ARN of the AWS WAF web ACL that is associated with the distribution. NOTE: If using the latest version of WAF (WAFv2), be sure to use the ARN. If using WAF Classic, use the ID. https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudfront_distribution#web_acl_id-3"
default = ""
}

Expand Down
Loading