Skip to content

Rename stub.%l to grader.%l in Communication tasks. - #1711

Merged
veluca93 merged 2 commits into
cms-dev:mainfrom
veluca93:communication-grader
Sep 7, 2026
Merged

Rename stub.%l to grader.%l in Communication tasks.#1711
veluca93 merged 2 commits into
cms-dev:mainfrom
veluca93:communication-grader

Conversation

@veluca93

Copy link
Copy Markdown
Contributor

Fixes #1705.

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.84772% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.46%. Comparing base (114df9c) to head (8b5dfc2).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cmscontrib/loaders/italy_yaml.py 0.00% 8 Missing ⚠️
cmscontrib/loaders/tps.py 0.00% 8 Missing ⚠️
cms/grading/tasktypes/Communication.py 85.71% 2 Missing ⚠️
cmstestsuite/unit_tests/cmscontrib/Update49Test.py 97.36% 1 Missing ⚠️
...te/unit_tests/grading/tasktypes/InteractiveTest.py 97.95% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1711      +/-   ##
==========================================
+ Coverage   55.05%   55.46%   +0.41%     
==========================================
  Files         339      342       +3     
  Lines       27401    27551     +150     
==========================================
+ Hits        15085    15282     +197     
+ Misses      12316    12269      -47     
Flag Coverage Δ
functionaltests 0.00% <0.00%> (ø)
unittests 55.46% <89.84%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@veluca93
veluca93 marked this pull request as ready for review August 22, 2026 16:04
@veluca93
veluca93 requested review from Virv12, gollux and prandla and removed request for gollux August 22, 2026 16:04

@prandla prandla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interactive is now the only task type to still call it "stub". presumably we should do the same thing there for consistency?

Comment thread docs/Task types.rst Outdated
Comment thread docs/Task types.rst
Comment thread cmscontrib/updaters/update_from_1.5.sql Outdated
@veluca93
veluca93 force-pushed the communication-grader branch 2 times, most recently from 7e280df to 41379ce Compare September 7, 2026 06:29
@veluca93

veluca93 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Interactive is now the only task type to still call it "stub". presumably we should do the same thing there for consistency?

Completely forgot about it :-) done in a second commit (still in the same PR and modifying the same updater)

@veluca93
veluca93 force-pushed the communication-grader branch from 41379ce to 8b5dfc2 Compare September 7, 2026 06:37
@veluca93
veluca93 merged commit 773ace8 into cms-dev:main Sep 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Rename stub.%l to grader.%l in communication tasks

2 participants