Skip to content

fix(tui): restore the accents six pt-BR, es-419 and ca strings lost - #6888

Open
Lstarsky0 wants to merge 1 commit into
codewhale-hq:mainfrom
Lstarsky0:fix/restore-missing-accents
Open

Lstarsky0 wants to merge 1 commit into
codewhale-hq:mainfrom
Lstarsky0:fix/restore-missing-accents

Conversation

@Lstarsky0

Copy link
Copy Markdown
Contributor

What and why

Six strings were written without their accents:

  • pt-BR CmdChangeTranslationQueued and CmdChangeTranslationUnavailable, the notes /change shows above the English release notes: versao em ingles, sera solicitada, traducao esta indisponivel, sessao atual nao tem.
  • pt-BR CmdHfDescription and CmdProfileDescription: configuracao.
  • es-419 CmdHfDescription: configuracion.
  • ca SetupStepSkipped: omes.

Everywhere else these packs spell the same words with their accents (pt-BR writes não in over 200 strings). This puts the accents back. Only the letters change; the wording is as it was.

Issue

No-Issue: six pt-BR, es-419 and ca strings lost their accents

How I tested it

  • Checked that each new value with its accents stripped equals the old value, so nothing but the accents moved.
  • python3 scripts/check-tui-locale-parity.py: PASS.
  • cargo test -p codewhale-localization: 54 passed.
  • cargo nextest run -p codewhale-tui --lib: 15245 passed, 44 failed, and the same 44 fail on main here. 41 need the extension host, which wants Node ^22.19 or >=24 and finds 23.11 on this machine; two are mcp::http_client tests that fail because of a local HTTP proxy; and parent_agent_surface_stays_within_measured_ceiling reads 90552 bytes against its Linux-measured ceiling, the same number on main.
  • cargo clippy -p codewhale-localization -p codewhale-tui --all-targets --all-features with CI's flags and cargo fmt --all -- --check: clean.

Checklist

  • One focused change, rebased on current main
  • cargo fmt --all passes, and tests cover new or changed behavior
  • If this adds or changes a user-facing feature, I updated its docs and its row in docs/features.toml (cargo test -p codewhale-tui --test feature_registry checks it) — n/a

Six strings were written without their accents: in pt-BR the two
/change translation notes ("versao em ingles", "traducao esta
indisponivel", "sessao atual nao tem") and the /hf and /profile
descriptions ("configuracao"), in es-419 the /hf description
("configuracion"), and in ca the skipped setup step ("omes"). Elsewhere
these packs spell the same words with their accents.

Put the accents back. Only the letters change; the wording is as it was.

Signed-off-by: Lstarsky0 <59827030+Lstarsky0@users.noreply.github.com>
@Lstarsky0
Lstarsky0 requested a review from Hmbown as a code owner October 7, 2026 09:09
@github-actions github-actions Bot added the contribution-gate Author not yet in .github/APPROVED_CONTRIBUTORS; a maintainer grants access with /lgtm label Oct 7, 2026
@Hmbown
Hmbown enabled auto-merge (squash) October 7, 2026 09:17

@Hmbown Hmbown left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution-gate Author not yet in .github/APPROVED_CONTRIBUTORS; a maintainer grants access with /lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants