Repository navigation
build: mark date-holidays-parser as external - #610
KristjanESPERANTO wants to merge 1 commit into
Conversation
|
Hi @KristjanESPERANTO, |
Dependency gets loaded at runtime, not bundled with the build. Removes unresolved dependency warning from rollup.
78e4e15 to
cdfa2ea
Compare
|
Thanks for looking into this! This PR only changes To verify, I built The CDN/UMD bundles in |
date-holidays-parseris loaded at runtime and shouldn't be bundled. Theexternalconfig tells rollup explicitly to leave it out.No behavior change - the package was already loaded at runtime. This just removes the unresolved dependency warning during build.
Before
After