Repository navigation
fix(AU-VIC): correct AFL Grand Final Friday for 2015, 2020 and 2022 - #678
Open
ryanduguid wants to merge 1 commit into
Open
ryanduguid wants to merge 1 commit into
ryanduguid wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
1st friday before Octoberrule for AFL Grand Final Friday gives the wrong date in three years, and it also adds the holiday before it existed.Sources:
The rule still gives the right date for the other years from 2016 to 2024, so I disabled and enabled the three dates instead of changing it.
I regenerated the AU-VIC fixtures with
--writetests --countries AU; only 2015, 2020 and 2022 changed.npm run lint,npx mocha(5,652 passing) andTEST_XXL=1 npx mocha(9,420 passing) pass locally.