Repository navigation
feat(bench): bench fork command + ciRunId run-action link - #550
Merged
Merged
Conversation
- POST /runs now accepts ciRunId (same-org validated); the runner passes
COMPUTESDK_RUN_ID which is injected into every Actions job env, linking
each benchmark run back to its producing Actions run.
- New 'bench fork <slug>' creates a private org benchmark whose
config.upstream records the catalog source (tracks upstream ref by
default, --ref pins, --as renames, --source-org overrides the curator org).
- GET /benchmarks/{slug} and /~/[org]/[slug] now return the platform's
source descriptor; the client exposes it via getForeignBenchmark.
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
dtice25
marked this pull request as ready for review
October 24, 2026 16:46
Contributor License AgreementAll contributors are covered by a CLA. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Devin resolved all 3 findings on 666a577
Fixed by Devin (3)
- Existing benchmark configuration lost on fork
- Fork run instructions point outside clone
- Pinned fork runs an unpinned revision
View all findings in Devin Review
- Re-forking onto an existing slug merges upstream into its config via PATCH instead of replacing config wholesale (keeps scoring/display). - Printed run instructions cd into the clone and git checkout --ref, so the pinned fork actually runs the pinned revision. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to benchmarks-platform#857 — the
benchside of the provider self-serve flow: link every run to its producing Actions run, andbench forkto create a private tracked fork of a catalog benchmark.ciRunIdpassthroughPOST /runsnow acceptsciRunId(validated same-org server-side).@benchsdk/runner'srun()passesCOMPUTESDK_RUN_ID— the platform injects it into every Actions job env — in bothcreateRuncalls, so a benchmark run dispatched in an Actions job links back to that job'sci_runsrow andGET /runs/{runId}returns anactionRunlink to the owning org.bench fork <slug>New top-level command in
@benchsdk/cli:GET /benchmarks/~/computesdk/{slug}returns the platform'ssourcedescriptor (newgetForeignBenchmark+BenchmarkSourceDescriptorin@benchsdk/api); fork thenPUT /benchmarks/{newSlug}withconfig.upstream = {org, slug, source}.upstreamis provenance only — the fork is a normal private org benchmark that stays private; the run command it prints (bench run <source.path> --benchmark <new> --provider <you>) executes inside the provider's own Actions checkout.Known pre-existing failure
pnpm typecheckin@benchsdk/runnerfails on ~7 errors in test files (scoring.test.ts,runner.test.ts,bench-config.test.ts—p95/p99/labeldrift on scoring types). Verified present on clean master, unrelated to this diff.Link to Devin session: https://app.devin.ai/sessions/9fb3a1ab18fb4035a9412995d0e1e68e
Open in Devin Desktop: https://app.devin.ai/desktop/session/9fb3a1ab18fb4035a9412995d0e1e68e?variant=devin
Requested by: @dtice25