Repository navigation
feat(benchsdk): bench reliability reader for type=reliability benchmarks - #563
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Adds getBenchmarkReliability to @benchsdk/api (GET .../reliability via benchmarkPath + queryString, handling both the range and day views) with BenchmarkReliabilityRange/Day wire types mirrored from the platform response, re-exported through @benchsdk/runner so the bench barrel carries them. Adds `bench reliability <slug>`: the aggregated range view (default last 7 days, day buckets) prints per-participant uptime/status plus scheduler stats and incidents; `--day <date> --participant <slug>` prints the per-slot strip for one participant on one local day. The two views take disjoint flags, validated before auth; --tz defaults to the machine zone; --json prints the raw response. Mirrors the MCP tool benchmarks_get_reliability. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration
Bot
force-pushed
the
devin/1793215272-bench-reliability-cli
branch
from
October 28, 2026 19:21
3b21600 to
e191c5a
Compare
dtice25
marked this pull request as ready for review
October 28, 2026 19:31
Contributor License AgreementAll contributors are covered by a CLA. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Devin resolved all 3 findings on e191c5a
Fixed by Devin (3)
- Unfiltered results from accepted date flags
- Requested reliability details disappear from tables
- Blank source organization selects another benchmark
View all findings in Devin Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the CLI reader for
type=reliabilitybenchmarks — the last piece of the rollout (docs/2026-09-29-benchmark-types.mdstep 6, twin of the platform'sbenchmarks_get_reliabilityMCP tool in benchmarks-platform#890).@benchsdk/api:getBenchmarkReliability(slug, input)→GET ${benchmarkPath(slug, sourceOrg)}/reliabilitywith the wire types (BenchmarkReliabilityRange/BenchmarkReliabilityDay/BenchmarkReliabilityInput) mirrored from the platform response. One method covers both views — narrow on'slots' in resultfor the day view.@benchsdk/runner: re-exports the reliability types so thebenchbarrel carries them.bench reliability <slug>:--from/--to --bucket day|hour): per-participant uptime/passed/degraded/failed + status, scheduler fired/missed totals, incidents, top errors.--day YYYY-MM-DD --participant <slug>): totals row + a one-mark-per-slot strip (./~/x/!) and the failing slots.--tzdefaults to the machine zone;--jsonprints the raw response.Docs in the same PR per repo rules:
benchsdk-cliREADME command list + thebenchsdk-cliskill's Commands section.Testing
npm run typecheck— clean.benchsdk-cli50/50,benchsdk-runner221/221 tests pass.benchbinary:reliability --helpand the flag-validation errors (--daywithout--participant,--participanton the range view, bogus--bucket,--metricson the day view).benchsdkhas one pre-existing live-smoke failure (updateRun400 on prod,integration.test.ts), unrelated — this diff only adds a new method.Link to Devin session: https://app.devin.ai/sessions/fdf951a9b9184f11a6d65e3c5056e907
Open in Devin Desktop: https://app.devin.ai/desktop/session/fdf951a9b9184f11a6d65e3c5056e907?variant=devin
Requested by: @dtice25