Repository navigation
Conversation
When `deadpool = false` (config or `--deadpool` CLI flag), the generated crate omits the deadpool client module, the `deadpool` feature, and the `deadpool-postgres` and `postgres` dependencies, leaving a plain tokio-postgres client. Defaults to true, so existing setups are unaffected. The basic_async_wasm example now uses this, dropping its generated deadpool module.
Contributor
|
Thanks for the PR. Just one question. What's the use case for this that adding |
Contributor
Author
|
You are not missing anything - mostly for dropping the dependency & unused module. I buy that this isn't worth the extra config and codegen changes. Thanks for looking :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
deadpool = false(config or--deadpoolCLI flag), the generated crate omits the deadpool client module, thedeadpoolfeature, and thedeadpool-postgresandpostgresdependencies, leaving a plain tokio-postgres client. Defaults to true, so existing setups are unaffected.The basic_async_wasm example now uses this, dropping its generated deadpool module.
This compliments query_typed work described by #305
How has this been tested?
I use this in production in a cloudflare workers + hyperdrive setup
The following has been done
feat:,fix:,chore:, ordocs:src, codegen for the repo has been run withcargo run --package test_integration -- --apply-codegenTests and linting
cargo fmtcargo test --allandcargo clippy