Move the Solana trades endpoint to the paginated v2 contract

[squadgazzz]

Description

EVM deprecated /api/v1/trades in favor of the paginated /api/v2/trades. The Solana trades route mirrored the deprecated shape: unpaginated, every fill of a busy owner in one response. Nobody has integrated it yet, so it moves straight to the v2 contract, /api/v2/trades with offset and limit, matching the EVM path and semantics.

Changes

• The trades route moves to GET /api/v2/trades and accepts offset and limit with the EVM defaults and bounds (0 and 10, limit 1 to 1000), rejecting a bad limit with InvalidLimit
• The trades query pages in SQL and returns newest first, like EVM v2
• The openapi spec documents the new path and parameters

How to test

Updated unit and database tests.

[github-actions]

Reminder: Please consider backward compatibility when modifying the API specification.
If breaking changes are unavoidable, ensure:

• You explicitly pointed out breaking changes.
• You communicate the changes to affected teams (at least Frontend team and SAFE team).
• You provide proper versioning and migration mechanisms.

---

Caused by:

• crates/solana-orderbook/openapi.yml

[claude]

Claude finished @squadgazzz's task in 1m 24s —— View job

---

PR Review

• Read changed files and gather context
• Compared against the EVM v2 trades implementation (get_trades_v2.rs / EVM openapi)
• Reviewed the trades route, DB query, openapi, and tests
• Posted inline findings

Verdict: Clean, well-scoped change that faithfully mirrors the EVM /api/v2/trades contract. Defaults/bounds (0, 10, 1..=1000), the InvalidLimit error message, validation ordering (short-circuit before DB access), the safe u64→i64 offset clamping, and SQL OFFSET/LIMIT on a deterministic ORDER BY all look correct. Tests cover both the paging behavior and the invalid-limit rejection. Since the v1 route was never integrated, moving straight to v2 is a reasonable non-breaking choice.

One minor, optional note posted inline:

• openapi.yml documents the limit bounds only in prose; the EVM v2 spec also encodes minimum: 1 / maximum: 1000 in the schema. Adding them keeps the machine-readable contract in parity.

Nothing blocking. 👍
· solana-orderbook/trades-pagination