Conversation
The keepBlanks hack is only required for xmlParseBalancedChunkMemory which doesn't take parser options. Only change the deprecated global before calling this function and restore it afterwards to avoid unwanted side effects. This reverts all code changes from a0183a0 which only doubled down on the original, flawed approach and introduced another deprecated access to the parser context struct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keepBlanks hack is only required for xmlParseBalancedChunkMemory which doesn't take parser options. Only change the deprecated global before calling this function and restore it afterwards to avoid unwanted side effects.
This reverts all code changes from a0183a0 which only doubled down on the original, flawed approach and introduced another deprecated access to the parser context struct.