Skip to content

Rules/Languages/hu/definitions.yaml: add a new rule, based the english new definitions.yaml rule (the of word related)… - #842

Open
hammera wants to merge 1 commit into
daisy:mainfrom
hammera:main
Open

hammera wants to merge 1 commit into
daisy:mainfrom
hammera:main

Conversation

@hammera

@hammera hammera commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Hi @MartheGjelstad, @moritz-gross or @NSoiffer ,

I added a small modification with Rules/languages/hu/definitions.yaml file to pass Translator audit tool the file.
The change happened the of word handling related, basic with the new english definitions.yaml new rule.
The tests into the main branch are passed correctly my local system.
Future automatically saves the .yaml and .rs files any editor in Linux into the git tree with crlf line format? A committer doed a .editor config into the upstream repo main branch, and this change is synced my fork too when I doed the synchronization afternoon.
Why need to change to the crlf line format? More people developing the community in Windows platform?
Me not matter this line ending format, not problem in Linux to save the proper files this line ending format.

Attila

…h new definitions rule

Signed-off-by: Attila Hammer <hammera@pickup.hu>
@github-actions

Copy link
Copy Markdown
Linux library size: 0.58 MiB (0.00%)
Revision Release liblibmathcat.so
Base (a3de867) 0.58 MiB (605,800 bytes)
PR (b01d5be) 0.58 MiB (605,800 bytes)
Change 0 bytes (0.00%)

Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run.

@hammera

hammera commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

Don't surprise, this small change related I choosed main branch, because the hu branch are not contains yet required other components to implement this new rule adding (hu branch last state in upstream I think is september 8 date).
So, now main branch destination in upstream level is more simpler this change related.

A question:
In translator audit tool, I see an interesting line with I don't no what means, previous in my hu branc I newer see this line with translator audit tool:
Rule order differs in SimpleSpeak_Rules.yaml: first difference at shared rule
position 12

Need handling this error? If need, how can possible doing the required change?

Attila

@moritz-gross

Copy link
Copy Markdown
Collaborator

This was added after the request in #619.
It only tells you if rules present in both languages have a different ordering.
If that is for a good reason, then you don't need to change it. If no, it might be easier to track if we have the same order in both.
Anyway, in most cases there shouldn't be any difference I think.

@moritz-gross

Copy link
Copy Markdown
Collaborator

regarding the CRLF/LF thing: I ran into the issue of Claude/Codex modifying the line endings, and as we use CRLF for (basically) all files anyway, I thought it'd make sense to set that as the standard. What do you think?

@hammera

hammera commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

@moritz-gross, ok, I understanding now.
What file affected this line related into the shared folder? If need, I would like investigate this issue to easyest your maintenance work.
Me not problem the CRLF default. Usual I editing all rule files and test file with Pluma text editor (I not often using AI yet during development, if need using AI services, I using any provider the free plan, so not the agentic AI mode).
The locall modells is not enough fast my machine to using development with AI agents.
So, if need use Claude or Gemini my work, I using any services with free plan, or use for example my machine the Claude Desktop if need doing a more complex job.
When pluma open for example in Mate environment a CRLF saved file, fortunatelly saves the file with crlf format.
By the way, before I forget:
Do I need to perform a rebase and a force push to include the .gitattributes change you made on October 1st?
I’m referring to this commit:

commit e1692f01841ab6fcfeb0f8d879507d0f294fc6b0
Author: Moritz Groß <hi@mgross.dev>
Date:   Thu Oct 1 01:52:38 2026 +0200

    Normalize tracked files to match .gitattributes (#843)

I forgot a thing:
with my hu branch have a change with affects the definitions.yaml and navigate.yaml files with translation related (navigate.rs and definition.rs files are affected too the tests directory), with Neil final not merged to the main branch, because need he doed a selective merge to the hu branch with my mistake (previous I doed always with git fetch main, git rebase -i upstream/main to syncing the main branch).
This is the affected commits the hu branch, I am not sure what PR's are not merged to the main branch after the RC release (latest merge are happened to main with my pr's I think in august 16 with main git log output, after this date happened the RC release I think:

commit 4d3d73ee14b187b077acc40fe30bc2b9790fa1d7
Author: hammera <hammera@pickup.hu>
Date:   Tue Sep 8 00:54:48 2026 +0200

    Critical important if fits the RC cicle before next RC subrelease: I fixed few rules with definitions.yaml and navigate.yaml, and implemented navigate.rs hungarian tests (#753)
    
    * Rules/Languages/hu/definitions.yaml: fix some intent translations
    
    Signed-off-by: Attila Hammer <hammera@pickup.hu>
    
    * Rules/Languages/hu/navigate.yaml: Fix some navigation translation rules
    
    Signed-off-by: Attila Hammer <hammera@pickup.hu>
    
    * Added hungarian navigation tests, based with english tests
    
    Signed-off-by: Attila Hammer <hammera@pickup.hu>
    
    * src/canonicalize.rs, src/chemistry.rs, src/tts.rs: apply clippy fixes with latest stable Rust release related
    
    ---------
    
    Signed-off-by: Attila Hammer <hammera@pickup.hu>

commit 64110b6356236f5ec7f68a862e07cb9589b9f6f4
Author: hammera <hammera@pickup.hu>
Date:   Tue Aug 25 00:53:46 2026 +0200

    tests/Languages/hu/mtable.rs: add separator and row separator tests, based with english new tests (#699)

commit 0d869333b0dd0d3fa9b7e047dd94adfaa5e1a43f
Author: hammera <hammera@pickup.hu>
Date:   Mon Aug 17 07:43:02 2026 +0200

    Fix a mistake after the selective merge with definitions.yaml and definition.rs test file (#697)
    
    Signed-off-by: Attila Hammer <hammera@pickup.hu>

The clippy fixes related part are not need from the hu branch.
I try doing an unified diff to apply changes to the main branch, but because already changed main branch content with CRLF, lot of patch applying are rejected or failed.
In hu branch, when I ran cargo test languages::hu command, have 611 localization tests.
How can handle this situation?
Rebase is not good now I think to the main branch.
You have any ydea how can I merge two changes to main branch contains the 611 right hungarian tests and full actual hungarian localization with have the hu branch?
I don't no when will be a next release, so would like always to have main branch the actual right hungarian translation and test fixes too.

Attila

@hammera

hammera commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

An interesting thing:
The Alert Translators on English File Changes workflow are failed my fork.
This workflow are need running with forks too?
Not only the upstream repo running this online workflow?

Attila

@moritz-gross

Copy link
Copy Markdown
Collaborator

An interesting thing: The Alert Translators on English File Changes workflow are failed my fork. This workflow are need running with forks too? Not only the upstream repo running this online workflow?

Attila

good point. not sure how this should be handled, but to me it makes sense to only run this on main repo.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants