Conversation
…h new definitions rule Signed-off-by: Attila Hammer <hammera@pickup.hu>
Linux library size: 0.58 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
|
Don't surprise, this small change related I choosed main branch, because the hu branch are not contains yet required other components to implement this new rule adding (hu branch last state in upstream I think is september 8 date). A question: Need handling this error? If need, how can possible doing the required change? Attila |
|
This was added after the request in #619. |
|
regarding the CRLF/LF thing: I ran into the issue of Claude/Codex modifying the line endings, and as we use CRLF for (basically) all files anyway, I thought it'd make sense to set that as the standard. What do you think? |
|
@moritz-gross, ok, I understanding now. I forgot a thing: The clippy fixes related part are not need from the hu branch. Attila |
|
An interesting thing: Attila |
good point. not sure how this should be handled, but to me it makes sense to only run this on main repo. |
Hi @MartheGjelstad, @moritz-gross or @NSoiffer ,
I added a small modification with Rules/languages/hu/definitions.yaml file to pass Translator audit tool the file.
The change happened the of word handling related, basic with the new english definitions.yaml new rule.
The tests into the main branch are passed correctly my local system.
Future automatically saves the .yaml and .rs files any editor in Linux into the git tree with crlf line format? A committer doed a .editor config into the upstream repo main branch, and this change is synced my fork too when I doed the synchronization afternoon.
Why need to change to the crlf line format? More people developing the community in Windows platform?
Me not matter this line ending format, not problem in Linux to save the proper files this line ending format.
Attila