Show genres on detail pages and fill them on scrobble - #1311
Open
crimsonsunset wants to merge 5 commits into
Open
crimsonsunset wants to merge 5 commits into
crimsonsunset wants to merge 5 commits into
Conversation
Owner
|
Thanks for this! Genres now show on several detail pages (album, artist, episode, podcast), so could you add before/after screenshots, or a short screen recording, to the PR description? If an AI agent did the work, screenshots of the running app (or a link to a published artifact page that shows them) are expected. The updated PR template in #1403 has a short section for this. Generated by Claude Code |
3 of 5 tasks
This was referenced Oct 2, 2026
Author
|
Added screenshots to the description: desktop and phone, light and dark, before and after where the page already existed. |
- The artist view already built genre_chips from MusicBrainz, but the template never rendered them. - Register a Genres sidebar section for music_artist so the layout settings can show and reorder it.
- After the write transaction, fill an album saved without genres from its MusicBrainz release group, then resync the play. - Plays fall back to the album artist's genres when the album has none. - Store artist genres from scrobbles as names, matching the artist page, instead of raw MusicBrainz genre objects.
Album and podcast show rows already store genres, but those detail pages never rendered them. Register the album sidebar section the same way artist pages already do.
Season metadata already copies the show's genres. The episode page never rendered them.
- Copy the first non-empty list onto the related rows that are still empty, including after a listen hook writes one. - Show artist genres on the album and artist pages when the album itself has none.
crimsonsunset
force-pushed
the
fix/music-genres
branch
from
October 3, 2026 23:07
7078166 to
c59c4c9
Compare
This was referenced Oct 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Music artist, album, podcast, and episode pages store genres and were not rendering them. Artist, album, and podcast pages now show those chips. An episode page shows the parent show's genres, which season metadata already copies down.
Scrobble fill is unchanged from the first commits: an album saved with no genres is filled from its MusicBrainz release group, and a play with no album genres falls back to the artist. After that, the first non-empty genre list is copied onto the artist, album, track, and play rows that are still empty. An album page with no album genres shows the artist's.
Rebased onto current
latest.Changes overview
In ticket / planned scope
Added while implementing
album.genreson the music album page and register the album sidebar sectionshow.genreson the podcast show pageseason_metadata.genreson the episode pageWhat ships
Key technical decisions
genresfrom the showTest plan
Related
latestand the genre-match commit addedScreenshots
music-artist
music-album