docs(rfcs): index 0018; correct 0017's GTK implementation status - #39
Merged
Merged
Conversation
- README index: add the missing 0018 row (merged in #36 without an index entry — the file exists on main but was unreachable from the index) - 0017: Dasher-GTK ships the self-managed check (UpdateChecker + Privacy opt-out); the 'not implemented anywhere' table was stale on arrival. History entry added per the keep-RFCs-current convention. Signed-off-by: will wade <willwade@gmail.com>
scripts/check_rfc_index.py + a minimal workflow: every NNNN-*.md in rfcs/ must have a README index row (0000-template exempt), every row must resolve to a real file, numbers must not repeat, rows ascend. Stdlib only; runnable locally as python3 scripts/check_rfc_index.py Verified both directions: green on this branch (with the 0018 row this PR adds), red when the row is removed. Ends the missing-index-row class (0018 merged unreachable; 0019's open PR repeated the gap). Signed-off-by: will wade <willwade@gmail.com>
Contributor
Author
|
Added the guard suggested on #38 to this PR (so it's green from birth — main without the 0018-row fix would fail it):
Verified: green on this branch (18 files / 18 rows), and red when the 0018 row is removed — i.e. exactly the regression that shipped in #36, which #38 would currently repeat for 0019 (add the row there and it passes this check on merge). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Housekeeping from the RFC review pass (#38 review comment):
0018-startup-loading-states.mdwithout an index entry; the file exists on main but is unreachable from the index. (0019 will need its row too — suggested on rfc: propose 0019 (the editor contract) + amend 0015 clause 8 caret triggers #38 that it be folded in there, since this PR can't know the final state.)UpdateChecker— the header is RFC 0017-branded — plus the "Check for updates" opt-out in Preferences → Privacy). The table said "None" / "Not implemented anywhere", stale on arrival. History entry added per the keep-RFCs-current convention.Also suggested on #38: a tiny CI guard that every
NNNN-*.mdinrfcs/has an index row — this repo has no workflows today; happy to add one if wanted (separate PR).DCO signed.