Skip to content

fix: declare jsonpickle runtime dependency - #385

Merged
wanghan-iapcm merged 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/issue-359-jsonpickle-dependency
Aug 27, 2026
Merged

wanghan-iapcm merged 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/issue-359-jsonpickle-dependency

Conversation

@njzjz-bot

Copy link
Copy Markdown

Summary

  • add jsonpickle to the declared runtime dependencies
  • ensure clean installs can import workflow modules without relying on transitive packages

Tests

  • parsed pyproject.toml with tomllib and verified jsonpickle is declared
  • imported dpgen2.flow.dpgen_loop
  • git diff --check

Closes #359

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Aug 23, 2026
@coderabbitai

coderabbitai Bot commented Aug 23, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8b1ac50c-9903-4f47-bd51-527ec0075393

📥 Commits

Reviewing files that changed from the base of the PR and between 6b01f29 and 534292e.

📒 Files selected for processing (1)
  • pyproject.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.43%. Comparing base (6b01f29) to head (534292e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   84.43%   84.43%           
=======================================
  Files         104      104           
  Lines        6110     6110           
=======================================
  Hits         5159     5159           
  Misses        951      951           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add jsonpickle to the project dependencies because workflow modules import it at runtime.

Closes deepmodeling#359

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.1
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@njzjz-bot
njzjz-bot force-pushed the fix/issue-359-jsonpickle-dependency branch from e6fef24 to 534292e Compare August 26, 2026 11:00
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 26, 2026
wanghan-iapcm

This comment was marked as outdated.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 27, 2026
@wanghan-iapcm
wanghan-iapcm dismissed their stale review August 27, 2026 03:33

Retracted: submitted without the maintainer's decision. Will re-review and let the maintainer choose the action.

wanghan-iapcm

This comment was marked as outdated.

@wanghan-iapcm
wanghan-iapcm merged commit e45c147 into deepmodeling:master Aug 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] Declare jsonpickle as a runtime dependency

2 participants