Repository navigation
API: handle OPTION requests on DomainViewSet correctly; make TTL handling on zone import explicit - #1215
Merged
Conversation
nils-wisiol
reviewed
Oct 13, 2026
nils-wisiol
approved these changes
Oct 13, 2026
peterthomassen
changed the title
Records without a TTL inherit the most recently stated TTL (RFC 1035 Section 5.1), and the SOA MINIMUM field serves as the default TTL only when no TTL has been stated at all (RFC 2308 Section 4). dnspython 2.9.0 made this its default behavior. The `rfc2308_ttl` parameter of `dns.zone.from_text()` is set explicitly nonetheless, and a test covers the behavior, as protection against regressions. Fixes #1262
peterthomassen
force-pushed
the
20260729_options-method
branch
from
October 13, 2026 16:15
c7b1206 to
cadc9b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.