Repository navigation
Conversation
|
Your commit should explain why do we need it and in this context why existing units are not enough. |
4bd714c to
b2c6667
Compare
Several existing bindings use the -millivolt suffix (for example trickle-voltage-millivolt). Unlike -microvolt, -millivolt is not currently recognised as a standard unit suffix, so these properties require an explicit $ref to uint32. Add millivolt to the list of standard units so the type can be inferred automatically. Suggested-by: Conor Dooley <conor@kernel.org> Signed-off-by: Sander Speetjens <sander.speetjens@gmail.com>
b2c6667 to
8f30bae
Compare
|
Changed my commit message to:
|
|
The reason we don't just have every unit is then we'd get the properties for the same thing with different units. So we have uV for everything up to ~4000V. If you need higher, then you can use -volts. |
There's already a user for this (in rtc.yaml) which has no obviously associated type, which is why I suggested this. You'd rather just explicitly add the type there? |
Yes. |
Add millivolt as a standard unit suffix.
This lets properties using the -millivolt suffix
automatically get the correct type without an explicit $ref.
Suggested-by: Conor Dooley conor@kernel.org
Signed-off-by: Sander Speetjens sander.speetjens@gmail.com