Generate the google-java-format default from the version catalog - #3045
Open
builtbyjuls wants to merge 1 commit into
Open
Generate the google-java-format default from the version catalog#3045builtbyjuls wants to merge 1 commit into
builtbyjuls wants to merge 1 commit into
Conversation
Member
|
Needs to check the other versions as well, replace all related usages. |
Author
|
Thanks. To confirm, should I generate constants for every catalog-backed formatter/runtime default in I found four catalog/default mismatches: Gson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2705.
Summary
gradle-buildconfig-pluginto the library build.BuildConfig.VERSION_GJFfrom thegoogle-java-formatversion catalog entry.Verification
./gradlew :lib:clean :lib:generateBuildConfigClasses :lib:compileJava --stacktrace./gradlew :lib:compileJava :testlib:test --tests com.diffplug.spotless.java.GoogleJavaFormatStepTest spotlessCheck --stacktraceThe focused test run executed 13 tests: 10 passed and 3 JVM-specific tests were skipped.
No
CHANGES.mdentry: this changes build maintenance only and does not change the current formatter default or user-facing behavior.