Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Quarantine evidence, validation and incomplete discovery checkpoint - 2026-11-13Supported category-only changeExact fact, without parameters:
Commit Decisive failure and passing controlBoth observations are actual, individually verified results for the exact fact.
Build 191699 / 31725, definition CI-SqlClient (1879), branch Image naming caveat: the nominal The actual error is Unique timeline mapping, with parent links and attempt checked:
The first ordinary attempt's only failure was this test; its four ordinary Supplemental observations and configuration limits
Enumerated interval, reconciliation and unfinished workNo reliable fully processed tagging checkpoint was found in the prior tagging Authenticated MCP rechecked all requested definition names/IDs and
Build inventory complete; whole-window per-test review incomplete. Authenticated build-result discovery covered builds 191931, 191888, 191699,
Targeted authenticated per-run pagination remained available and was used Three runs were fully paged and reconciled, 9,024 unique result identities:
Run 3710387's server statistics contain two separate Passed entries: Run/result identity, build linkage, outcome and JSON/HTTP 200 were verified Candidates not added:
The unconfirmed candidates' additional result/job/timestamp enrichment and Checkpoint NOT ADVANCED. The next tagging run must rescan at least its full Local category validation and executionProject: dotnet test src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj -f net10.0 --no-restore -c Release --list-tests --filter "FullyQualifiedName~SplitPacketTest&category=flaky" -v:qInitial attempt: failed NETSDK1004, missing this worktree's assets file. dotnet test src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj -f net10.0 -c Release --list-tests --filter "FullyQualifiedName~SplitPacketTest&category=flaky" -v:q
dotnet test src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj -f net462 --no-restore -c Release --list-tests --filter "FullyQualifiedName~SplitPacketTest&category=flaky" -v:qBoth built and passed discovery. Each selects exactly dotnet test src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj -f net10.0 --no-build --no-restore -c Release --list-tests --filter "FullyQualifiedName~SplitPacketTest&category!=failing&category!=flaky&category!=interactive" -v:q
dotnet test src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj -f net462 --no-build --no-restore -c Release --list-tests --filter "FullyQualifiedName~SplitPacketTest&category!=failing&category!=flaky&category!=interactive" -v:qBoth passed discovery: exactly dotnet test src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj -f net10.0 --no-build --no-restore -c Release --filter "FullyQualifiedName=Microsoft.Data.SqlClient.ManualTesting.Tests.SplitPacketTest.MARSSplitTest&category=flaky" -v:q --logger 'trx;LogFileName=mars-net10.trx' --results-directory 'C:\Users\mdaigle\.copilot\session-state\83c8f312-cbf8-435c-8fdd-75a34f1d32ca\files\validation' --blame-hang-timeout 2m
dotnet test src\Microsoft.Data.SqlClient\tests\ManualTests\Microsoft.Data.SqlClient.ManualTests.csproj -f net462 --no-build --no-restore -c Release --filter "FullyQualifiedName=Microsoft.Data.SqlClient.ManualTesting.Tests.SplitPacketTest.MARSSplitTest&category=flaky" -v:q --logger 'trx;LogFileName=mars-net462.trx' --results-directory 'C:\Users\mdaigle\.copilot\session-state\83c8f312-cbf8-435c-8fdd-75a34f1d32ca\files\validation' --blame-hang-timeout 2m
git diff --check
Related proposals, publication and release targetRead-only deduplication/context: #5038 Upstream main at the release-target recheck: Live publication verification: the PR is open, source and target repositories The initial pre-assignment milestone validation failed at 14:18:07Z; subsequent All changes are confined to the automation's isolated worktree and its upstream |
There was a problem hiding this comment.
🔵 Needs a closer look
Review remains blocked because the required trusted, immutable-source policy references were not supplied, and worktree copies cannot substitute.
No open issues 🎉
What changed in this PR
Quarantines the intermittent MARSSplitTest using the existing flaky-test mechanism, without changing test logic, product code, or pipelines.
Changes:
- Adds a method-level
flakycategory affecting bothnet462andnet10.0. - Adds a comment documenting the observed pre-login handshake timeout.
- Preserves the existing
FullHeaderTestquarantine and four ordinary sibling tests.
| File | Description |
|---|---|
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SplitPacketTest/SplitPacketTest.cs |
Adds the quarantine trait and observed-error comment to MARSSplitTest. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5065 +/- ##
==========================================
+ Coverage 68.99% 69.33% +0.33%
==========================================
Files 314 314
Lines 45857 69744 +23887
==========================================
+ Hits 31638 48354 +16716
- Misses 14219 21390 +7171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🤖 This pull request was created by a fully automated workflow.
Description
Add
[Trait("category", "flaky")]and an observed-error comment to this one fact:Microsoft.Data.SqlClient.ManualTesting.Tests.SplitPacketTest.MARSSplitTestIt intermittently times out consuming the pre-login handshake acknowledgement through its test-owned TCP proxy. The exact fact failed and passed on the same upstream-main revision in the same job. Method-level quarantine affects this fact on both frameworks; all bodies, existing categories, four ordinary siblings and pipelines remain unchanged.
45aacd87d3b9The unchanged-job retry supplies the comparable passing control. This is quarantine, not a root-cause repair or stability claim. Complete collapsed evidence record includes the image-naming caveat and exact validation commands/results.
Issues
Related: #5047 already quarantined the distinct
FullHeaderTestand is untouched; #5038 is a separate pending certificate proposal. #4980 and #4996 are merged discovery inputs; #5039 is separate fixes/probation work. No issue is closed.Testing
Built and verified actual xUnit/VSTest selection on
net10.0andnet462: quarantine selects this fact plus the existing FullHeader control; ordinary selection excludes both and selects four siblings.git diff --checkpassed.Local execution was not passing: net10.0 skipped because configuration predicates threw
TargetInvocationException; net462 executed and failed with a pre-login timeout. Neither counts as a pass. Three CI run inventories (9,024 results) were reconciled; broader 14-day per-test review remains incomplete following a build-wide MCP transport failure. Discovery checkpoint not advanced.Guidelines
Please review the contribution guidelines before submitting a pull request: