Repository navigation
Clarify StringLengthAttribute.MaximumLength is read-only - #13145
Merged
Merged
Conversation
Closed
Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix MaximumLength setter documentation
Clarify StringLengthAttribute.MaximumLength is read-only
Oct 2, 2026
gewarren
approved these changes
Oct 2, 2026
gewarren
marked this pull request as ready for review
October 2, 2026 17:09
gewarren
enabled auto-merge (squash)
October 2, 2026 17:09
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation now accurately matches the property signature.
Review effort: Balanced
Findings: None
What changed in this PR
Clarifies that StringLengthAttribute.MaximumLength is read-only, resolving #13144.
Changes:
- Corrects the property summary and value description.
| File | Description |
|---|---|
xml/System.ComponentModel.DataAnnotations/StringLengthAttribute.xml |
Documents MaximumLength as getter-only. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
auto-merge was automatically disabled
October 5, 2026 17:26
Pull request was closed
gewarren
enabled auto-merge (squash)
October 5, 2026 17:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaximumLengthis getter-only, but its documentation said it could be set.Internal previews
Build report