Repository navigation
Document runtime-async MethodImpl enum members - #13157
Merged
Merged
Conversation
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add documentation for System.Reflection APIs in .NET 10.0
Document runtime-async MethodImpl enum members
Oct 6, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Both summaries accurately describe the runtime-async flags and align with the runtime specification.
Review effort: Balanced
Findings: None
What changed in this PR
Documents the .NET 10 runtime-async flags that previously had placeholder summaries.
Changes:
- Describes
MethodImplOptions.Async. - Describes
MethodImplAttributes.Async.
| File | Description |
|---|---|
xml/System.Runtime.CompilerServices/MethodImplOptions.xml |
Documents the runtime-async option. |
xml/System.Reflection/MethodImplAttributes.xml |
Documents the corresponding metadata flag. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jkotas
reviewed
Oct 6, 2026
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
jkotas
reviewed
Oct 6, 2026
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
gewarren
approved these changes
Oct 6, 2026
gewarren
left a comment
gewarren
left a comment
Collaborator
There was a problem hiding this comment.
No need to add a Markdown section unless you specifically need it for formatting.
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
gewarren
approved these changes
Oct 6, 2026
jkotas
enabled auto-merge (squash)
October 6, 2026 19:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.NET 10 added
AsynctoMethodImplAttributesandMethodImplOptions, but both API reference entries had placeholder summaries.Fixes dotnet/runtime#120501
Internal previews
Build report