Fix nil crash in Hammerspoon music display() - #339
Merged
Merged
Conversation
hs.itunes.getPosition()/hs.spotify.getPosition() can return nil when no playback position is available, crashing display() on arithmetic with nil. Extract the percent calculation into lib.percentComplete, nil- and zero-total safe, and cover it with unit tests.
Review flagged that an unclamped percent (out-of-range current, or negative input) could produce a nonsensical display value now that percentComplete is a general-purpose lib function; clamp it and cover the boundary with tests.
go install/test/vet hit the same sandboxed-write-permission class of failure qlty already documents a HOME workaround for, but against ~/.argus/cache/go-build instead of ~/.qlty/logs. Capture the fix so future sessions don't have to rediscover it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hs.itunes.getPosition()/hs.spotify.getPosition() can return nil when no playback position is available, crashing display() on arithmetic with nil. Extracts the percent-of-track math into a nil- and zero-total-safe lib.percentComplete, clamped to 0-100, with unit tests covering the nil/zero/rounding/out-of-range cases. Also documents a GOCACHE sandbox workaround for go install/test in the Pre-Completion Checklist.
Co-Authored-By: Claude noreply@anthropic.com