Decoder fixes - #250
Merged
Merged
Decoder fixes#250
Conversation
The performance optimization that migrated to the use of a perfect hash function [1] has left the decoder overly permissive with regards to invalid words that has to a known value. We fix this by a subsequent check powered by a constant-time lookup. Thus, most of the performance gains of [1] should remain. Also, remove an unused clippy allow attribute. [1] c7fd1ae
Instead, verify the expected length first and access directly afterwards. This protects against malformed long words.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #250 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 1123 1138 +15
=========================================
+ Hits 1123 1138 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
Author
|
Published as part of 0.5.0. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.