Skip to content

Ask before closing or opening projects nested below the selection - #4332

Open
vogella wants to merge 1 commit into
masterfrom
close-nested-projects
Open

Ask before closing or opening projects nested below the selection#4332
vogella wants to merge 1 commit into
masterfrom
close-nested-projects

Conversation

@vogella

@vogella vogella commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Close Project and Open Project acted on exactly the selected projects, so a project that physically contains other projects, such as a Maven or Gradle root, left its modules open, and reopening the root brought back only the root. Open Project then asked about referenced projects from inside its job, a second dialog for the same action.

Both actions now report the nested projects in one dialog with an "Include nested projects" check box (off by default) and the usual Close or Open and Cancel buttons. Open Project asks about referenced projects in that same dialog with a second check box backed by the existing preference, so there is at most one question per action, and Cancel now opens nothing instead of leaving the first project open. A Remember my decision toggle stores each answer in its workspace preference, shown next to the existing settings. Nothing is asked when neither applies, and Close Unrelated Projects keeps its own confirmation.

This supersedes #4344, which is now part of this change. Verified against a workspace where one root project contains 757 nested projects shown in the hierarchical Project Explorer: closing the root closed all 758, opening it brought all 758 back. The tests answer the dialog programmatically and cover both check boxes, the remembered answers in both directions, and Cancel.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Test Results

   858 files  ± 0     858 suites  ±0   48m 11s ⏱️ - 2m 31s
 8 338 tests +24   8 095 ✅ +24  243 💤 ±0  0 ❌ ±0 
20 868 runs  +57  20 198 ✅ +57  670 💤 ±0  0 ❌ ±0 

Results for commit 52eedcb. ± Comparison against base commit 72be953.

♻️ This comment has been updated with latest results.

@vogella
vogella force-pushed the close-nested-projects branch 3 times, most recently from e908070 to 676931c Compare September 2, 2026 11:00
@vogella
vogella force-pushed the close-nested-projects branch from 676931c to 41c96cc Compare September 10, 2026 10:34
@vogella vogella changed the title Ask before closing projects nested below the selection Ask before closing or opening projects nested below the selection Sep 10, 2026
@vogella
vogella force-pushed the close-nested-projects branch from 41c96cc to d39f226 Compare September 10, 2026 11:03
Close Project and Open Project acted on exactly the selected projects,
so a project that physically contains other projects, such as a Maven
or Gradle root, left its modules open, and reopening the root brought
back only the root. Open Project then asked about referenced projects
from inside its job, a second dialog for the same action.

Both actions now report the nested projects in a dialog with an
"Include nested projects" check box, unchecked by default, and a
"Remember my decision" toggle that stores the answer in two new
workspace preferences, shown next to the setting for opening referenced
projects. Open Project asks about referenced projects in that same
dialog, with a second check box backed by the existing preference, and
its job no longer prompts. Nothing is asked when neither applies.
CloseUnrelatedProjectsAction opts out, it already confirms the projects
it computes. The location matching and the dialog are shared by both
actions.

Assisted-by: multiple AI agents and layers of automated tooling 🤖
@vogella
vogella force-pushed the close-nested-projects branch from d39f226 to 52eedcb Compare September 10, 2026 11:19
@vogella

vogella commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author
nested-projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant