Support the full CSS font-weight grammar - #4369
Merged
Merged
Conversation
Only the literal 'bold' had an effect, every other value cleared the bold bit, so 'font-weight: 600' rendered lighter than bold. In the font shorthand a bare number was taken as a size and 'lighter' as a family name, so both lost their weight. font-weight now accepts 1 to 1000 plus normal, bold, bolder and lighter. SWT fonts have no weight axis, so 600 and above select a bold face. In the shorthand a bare 100 to 900 is a weight. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSS engine only understood the literal
boldforfont-weight; every other value, including600orbolder, cleared the bold bit. In thefontshorthand a bare number was always read as a size andlighteras a family name, so both dropped the weight silently.font-weightnow accepts1to1000plusnormal,bold,bolderandlighter, with the relative keywords resolved against the inherited weight. SWT fonts have no weight axis, so600and above select the bold face and everything below the regular one. In the shorthand a bare100to900is a weight. This makes stylesheets written against standard CSS behave as expected instead of ending up lighter than intended.