Repository navigation
Tech: extract the proxy rule parser into ProxyRule - #35
Merged
Merged
Conversation
Frontier::proxy() parsed the rule string, built the route config and registered the route in a single method. The parsing now lives in ProxyRule, a value object with its own unit tests, and the method only registers the route. The existing proxy tests cover the registered routes and keep passing unchanged, so the behavior is preserved. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/ProxyRule.php, a readonly value object withfromString()that parses one entry ofFRONTIER_PROXY_RULES(exact,cache,methods(...),middleware(...),replace(...),rewrite(...)) plusurl(),routeUri()andreplaces()to resolve the parts that depend on the host.Frontier::proxy()shrinks from ~90 to ~30 lines and only registers the route. The dead$methods = []assignment goes away.tests/Unit/ProxyRuleTest.phpwith 13 tests covering each segment, defaults, segment order and malformed segments. Until now the parser was only exercised through HTTP tests.Pure refactor, no behavior change. The 42 existing tests pass without edits.
Test plan
composer test(55 passed)vendor/bin/pint --test🤖 Generated with Claude Code