fix: resolve latest addon version before pod identity lookup - #8867
Open
atharvaHJoshi wants to merge 1 commit into
Open
fix: resolve latest addon version before pod identity lookup#8867atharvaHJoshi wants to merge 1 commit into
atharvaHJoshi wants to merge 1 commit into
Conversation
Signed-off-by: Atharva Joshi <josh.atharva2005@gmail.com>
Contributor
|
Hello atharvaHJoshi 👋 Thank you for opening a Pull Request in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7841
What this PR does
eksctl update addonfailed withError: getting recommended policies for addon vpc-cniwhen the config used
version: latesttogether with pod identity configuration(e.g.
useDefaultPodIdentityAssociations: true).Root cause
pkg/actions/addon/update.goresolvedlatestinto a concrete version and set it on theUpdateAddoninput, but never wrote it back intoaddon.Version. Later,getRecommendedPoliciesForPodIDcalls the EKS APIDescribeAddonConfigurationwithAddonVersion: addon.Version— the literal string"latest"— which the EKS API rejects.The create-addon path (
create.go) already didaddon.Version = versioncorrectly.The error was also swallowed (
%sinstead of%w), hiding the actual cause.Changes
addon.Versionafter resolvinglatest(same pattern as
create.go).cause surfaces.
DescribeAddonConfigurationreceives the resolvedversion (not
latest) and thatUpdateAddonreceives the resolved version plus thepod identity associations.
Validation
go build ./...golangci-lint run --timeout=30m ./pkg/...go test ./pkg/actions/addon/...(127 specs pass)Pre-existing, unrelated failures in
pkg/infoandpkg/iam/oidcare environmental(kubectl/
cfsslmissing locally) and remain unchanged.