Repository navigation
[#967] Qt interactive adjustment dialog stuck after Continue / with Auto Output Levels - #968
Merged
eoyilmaz merged 1 commit intoJul 28, 2026
Conversation
…dialog during Auto Output Levels detection AdjustmentController._on_poll() ported wx's Worker.progress_handler() swap-to-progress-dialog logic but dropped its `not self._detecting_video_levels` guard. Worker.calibrate() always runs detect_video_levels() (a dispread patch measurement) before dispcal when Output Levels is Auto, and that pre-check emits the same "Patch N of M" progress text the swap looks for. Without the guard, a slow Auto detection got mistaken for real calibration progress, swapping the still-blank adjustment window out for a plain progress dialog. Once dispcal's interactive menu later re-showed the adjustment window, the stale progress dialog was never hidden, leaving both on screen, and `_swapped` stuck `True` meant the poll never handed off cleanly for the real post-"Continue" measurement either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AdjustmentController._on_poll()ported wx's swap-to-progress-dialog logic (Worker.progress_handler()) but dropped itsnot self._detecting_video_levelsguard, so a slow Auto Output Levels pre-check (Worker.detect_video_levels(), which runs adispreadpatch measurement beforedispcal) got mistaken for real calibration progress and swapped the still-blank "Interactive Display Adjustment" window out for a plain progress dialogdispcal's interactive menu later re-showed the adjustment window, the stale progress dialog was never hidden (both stayed on screen), and_swappedbeing stuckTruemeant the poll never handed off cleanly for the real post-"Continue" measurement either, leaving the window unresponsive until it was force-closed (aborting the run)DisplayCAL/VERSIONto3.10.0.dev81Test plan
pytest tests/test_ui_worker_runner.py tests/test_ui_display_adjustment_window.py tests/test_ui_display_adjustment.py(103 passed, 2 unrelated skips)