Conversation
`go.mod` already requires `go 1.25.0` and CI only tests 1.25/1.26, so `operation_name_legacy.go`'s `!go1.24` build tag was already dead code — it can never be compiled by this module. Its go1.24+ counterpart's `go1.24` tag was likewise always true. - Removed `operation_name_legacy.go` (the `unicode.IsSpace`-based first-word parser for pre-1.24 Go). - Renamed `operation_name_go124.go` to `operation_name.go`, dropping its now-unconditional `go1.24` build tag. `defaultSpanNameCtxFunc` keeps its `strings.FieldsSeq`-based implementation, unconditionally. - Same reasoning applied to `tracer_benchmark_test.go`'s `go1.24` tag (gating `testing.B.Loop`, also go1.24+) — dropped it too. No behavioural change; `go build`, `go vet`, `gofmt -l`, and `go test -race ./...` all pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
|
LGTM; WDYT @obitech ? |
costela
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go.modalready requiresgo 1.25.0and CI only tests 1.25/1.26, sooperation_name_legacy.go's!go1.24build tag was already dead code — it can never be compiled by this module. Its go1.24+ counterpart'sgo1.24tag was likewise always true.operation_name_legacy.go(theunicode.IsSpace-based first-word parser for pre-1.24 Go).operation_name_go124.gotooperation_name.go, dropping its now-unconditionalgo1.24build tag.defaultSpanNameCtxFunckeeps itsstrings.FieldsSeq-based implementation, unconditionally.tracer_benchmark_test.go'sgo1.24tag (gatingtesting.B.Loop, also go1.24+) — dropped it too.No behavioural change;
go build,go vet,gofmt -l, andgo test -race ./...all pass.