Repository navigation
Conversation
Signed-off-by: Mark Liu <mark@prove.com.au>
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mark-liu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @mark-liu! It looks like this is your first PR to falcosecurity/falco 🎉 |
|
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
|
Hey @mark-liu . Thank you for this contribution, but as mentioned in #3895 (comment), the issue was already fixed, and the fix was delivered with Falco 0.44.0. |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Escapes control characters in plain text Falco output so event field values cannot inject forged lines or terminal control sequences.
nlohmann::json::dump()so structured consumers do not get double-escaped valuesWhich issue(s) this PR fixes:
Closes #3895
Special notes for your reviewer:
Assumption: downstream JSON consumers expect decoded
output_fieldsvalues to stay unchanged.Out of scope:
format_event()still assumes a non-empty rule output format before indexingmessage_format[0].Does this PR introduce a user-facing change?: