Repository navigation
fix: load no evttype false positive - #3918
Conversation
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…conditions Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…oad conditions Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
|
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
| # -DFALCOSECURITY_LIBS_VERSION=dev ..` | ||
| if(NOT FALCOSECURITY_LIBS_VERSION) | ||
| set(FALCOSECURITY_LIBS_VERSION "0.25.4") | ||
| set(FALCOSECURITY_LIBS_VERSION "01b5cf7ffb294bc6605bc745b327e43f8cf55b40") |
There was a problem hiding this comment.
Just wondering: is the semantic version number being dropped or is it just for this change to be functioning ?
There was a problem hiding this comment.
This updates the current libs version, bringing in the libs implementation this PR depends on.
The temporary bump is equivalent to #3923
Later, FALCOSECURITY_LIBS_VERSION will be bumped with the correct version once a stable libs release is out.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, leogr, sgaist The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
Falco was emitting
LOAD_NO_EVTTYPE("Rule matches too many evt.type values...") for rules whose condition is statically unsatisfiable - notably the documentednever_trueidiom (evt.num=0) - which is the opposite of what's actually happening: those rules match nothing.Since falcosecurity/libs#3009, the event-code analyzer resolves such conditions to the empty set. This PR bumps libs to latest master and changes the warning gate to fire only on genuinely broad conditions (
size() > 100), instead of conflating "matches nothing" with "matches too much".Which issue(s) this PR fixes:
Fixes #3883
Special notes for your reviewer:
... and never_truetuning pattern would start producing empty sets and trigger the old warning.evt.type=open and evt.type=close) now load silently too. This is intentional: a dead-rule diagnostic is a separate UX design (with its own suppressibility), out of scope here.falco -Vreports "Ok" instead of "Ok, with warnings" for placeholder-only rules, and theirfalco -Levents list is no longer the full set./milestone 0.45.0
Does this PR introduce a user-facing change?: