Repository navigation
update(cmake): bump bundled OpenSSL to 3.5.9 LTS - #4053
Merged
Merged
Conversation
Move the bundled TLS library from OpenSSL 3.1.4 to the supported 3.5 LTS series. Update the source archive checksum to the verified upstream value. Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Ubuntu 26.04's rpm package owns sysusers.attr, which conflicts with the systemd-rpm-macros package installed through Alien. This fails before checkout and prevents release packages from building. Restore the runner version on which the same package setup succeeds. Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
The sanitizer package links against libasan.so.8. Install libasan8 instead of libasan5, which is unavailable on the current Ubuntu runner and prevents the package tests from starting. Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
The pinned event-generator creates child executables by hard-linking its binary from RUNNER_TEMP into /tmp. Ubuntu 26.04 runners place these paths on different filesystems, causing test setup to fail with EXDEV. Restore the Ubuntu 24.04 runner on which both driver suites passed. Keep the sanitizer tests on their current runner to match the sanitizer build. Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
sgaist
approved these changes
Oct 27, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, sgaist The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 75bce02f95da1425a35d8ba9b2444b7e59beb153 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Updates bundled OpenSSL from
3.1.4to3.5.9 LTSfor Falco0.45.2. Falco embeds this library, so refreshing the container's OpenSSL package does not update the copy used by Falco.The source archive SHA-256 matches both the upstream checksum file and the GitHub release asset digest. The OpenSSL change updates the archive URL and checksum, keeping the existing build arguments.
The package build also needs the amd64 release runner pinned to
ubuntu-24.04. Onubuntu-latest, Ubuntu 26.04'srpmpackage conflicts with the importedsystemd-rpm-macrospackage oversysusers.attr, failing before checkout. This restores the runner version where the same package setup passed.The package test workflow installs
libasan8, matching the sanitizer binary's verifiedlibasan.so.8dependency. The previouslibasan5package is unavailable on the current runner and prevented those tests from starting.The amd64 event-generator job also uses
ubuntu-24.04. On Ubuntu 26.04, the pinned action cannot hard-link its executable fromRUNNER_TEMPinto/tmp, failing withinvalid cross-device linkbefore generating events. The same action previously passed all636tests for each driver on Ubuntu 24.04. Sanitizer tests stay on their current runner to match the sanitizer build.Special notes for your reviewer:
These commits are also carried in the cumulative release sync:
Validation:
cmake-format 0.6.13andgit diff --checkpass.3.5.9and curl8.7.1built on macOS arm64. An integration harness using httplib0.23.1passed 11 TLS checks: TLS 1.2/1.3, custom CA trust, wrong CA/hostname rejection, and mutual TLS acceptance/rejection.334b94f9a901b50ad243643f531bd97c477dd131, including Linux package builds on both architectures, sanitizer package tests, event-generator tests with both drivers, and CodeQL.3.5.9; development unit-test jobs use system dependencies.Completed CI:
N.B. This adopts OpenSSL's default TLS security level
2. RSA/DSA/DH keys below2048bits and EC keys below224bits are rejected. Deployments using weaker certificates or DH parameters must replace them, including custom HTTPS output and webserver/mTLS configurations. The native tests use RSA2048and SHA-256 without lowering the security level.Upstream release:
Does this PR introduce a user-facing change?: