Repository navigation
Conversation
A $ that is not ${...} or $ skipped the rest of the value, so a later ${VAR} stayed literal.
Signed-off-by: anandhx <anandhuashok6959@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anandhx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
There is not a label identifying the kind of this issue or PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
Summary
yaml_helper::pre_process_env_vars()treatsand `{...}` as tokens. A plain `$` (as in `C:\Users\HP` or) used to skip the rest of the value, so a later `` was left unexpanded.The scan now moves one character forward for a plain
$and keeps expanding the rest of the value.{VAR}still becomes the literal ``.Test plan
{ENV_VAR},ENV_VAR, side-by-side escaped and expanded variables, and an unset variableC:\Users\HP/keepsC:\Users\HPand expands the variablecostandENV_VAR/expand only the `` tokenunit_tests/falco/test_configuration_env_vars.cppcovers those three values. This machine has no C++ compiler, so that gtest binary was not built hereFixes #4064
Made with Cursor