Repository navigation
Pure rust "connection rejected" regression fixed - #189
Merged
Merged
Conversation
76621aa(#179) made read_with() preserve unconsumed bytes across calls instead of silently dropping them. That surfaced two latent bugs that were previously harmless only because leftovers were discarded: - execute2's closure called parse_response() right after parse_sql_response(), but the trailing op_response is framed with its own op_code like every other response on the wire. Skipping it left the response's own [op_code=9] sitting in pending, which the next read (e.g. commit_retaining) misread as the following operation's op_code, producing "Connection rejected with code 1 (Connect)". - parse_status_vector() had no arm for isc_arg_warning (18). Any status vector containing a warning (e.g. from CREATE USER) hit the catch-all "Invalid / Unknown status vector item" error before consuming the warning's code word, leaving pending misaligned for every subsequent read and cascading into garbage op_codes during rollback/detach.
Coverage Report for CI Build 34219335725Coverage at 43.45% (no base build to compare)Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
76621aa(#179) made read_with() preserve unconsumed bytes across calls instead of silently dropping them. That surfaced two latent bugs that were previously harmless only because leftovers were discarded: