Skip to content

wip: test Firebase 13 - #172

Open
ncooke3 wants to merge 1 commit into
firebase:masterfrom
ncooke3:patch-1
Open

ncooke3 wants to merge 1 commit into
firebase:masterfrom
ncooke3:patch-1

Conversation

@ncooke3

@ncooke3 ncooke3 commented Sep 24, 2026

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Firebase dependency in Package.swift to point to the main branch instead of a version range. However, this change introduces a syntax error because the closing parenthesis for the .package declaration was commented out, which will cause a compilation error. It is recommended to fix the syntax by properly closing the parenthesis.

Comment thread Package.swift
Comment on lines +21 to +22
// "7.0.0"..<"14.0.0"),
branch: "main",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The closing parenthesis ) for the .package dependency is missing because the line containing it was commented out. This will result in a Swift Package Manager compilation error. Removing the commented-out line and properly closing the parenthesis fixes this issue.

                 branch: "main"),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant