Repository navigation
fix(pdf): return a conversion error when the PDF parser panics - #218
Open
gauravch-code wants to merge 1 commit into
Open
gauravch-code wants to merge 1 commit into
gauravch-code wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #189.
A PDF with a missing inline-image colour-space field can trigger a panic in the PDF parser and abort the Node host process.
Catch unwinding panics at the PDF conversion boundary and return a malformed conversion error. Add regressions for the reported failure and an inline image with a valid colour space.
Validation on Windows:
The default panic diagnostic still appears on stderr. Browser/Wasm runtime behavior has not been verified.
Summary by cubic
Catches a PDF parser panic on inline images that miss a colour-space field, returning a malformed conversion error instead of unwinding across a native binding and aborting the Node host process.
Written for commit 176e7ef. Summary will update on new commits.