Repository navigation
v0.7.6: --parquet-only and --parquet -c - #7
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Restore removed public APIs, prevent header output in --parquet-only, and make release validation portable.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 4
Open (5)
What changed in this PR
Adds --parquet-only and --parquet -c support, reorganizes integration tests, and updates release validation for v0.7.6.
Changes:
- Adds Parquet-only output and compression support.
- Refactors and expands integration tests.
- Updates validation scripts, documentation, and package metadata.
- Removes several public compatibility APIs.
| File | Description |
|---|---|
tests/tsv.rs |
TSV tests. |
tests/test.rs |
Replaced by focused test modules. |
tests/scripts/validate_release.sh |
Release validation updates. |
tests/scripts/compare_tsv_bcftools.py |
TSV comparison utility. |
tests/reports.rs |
Report tests. |
tests/parquet.rs |
Parquet behavior tests. |
tests/maf.rs |
MAF tests. |
tests/common/mod.rs |
Shared test helpers. |
tests/cli.rs |
CLI tests. |
tests/annotations.rs |
Annotation tests. |
src/summary.rs |
Summary refactoring. |
src/reformat_vcf.rs |
Streaming output changes and removed APIs. |
src/read_vcf_gz.rs |
VCF reading refactoring. |
src/parquet_writer.rs |
Streaming Parquet writer changes. |
src/main.rs |
New CLI modes and output handling. |
src/extract_sample_info.rs |
Sample extraction updates. |
src/essentials_fields.rs |
MAF conversion updates and removed API. |
README.md |
Documents v0.7.6 and new options. |
Cargo.toml |
Version metadata update. |
Cargo.lock |
Locked version update. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+144
to
147
| /// Convert a single-ALT record to a MAF row, reading the depth columns from explicitly named | ||
| /// samples. `tumor` is the sample the t_* columns describe; `normal` populates the | ||
| /// matched-normal columns. Passing `None` for either keeps the historical behaviour of | ||
| /// using the first sample that declares `DP`. |
Comment on lines
82
to
83
| fn build_tsv_schema(headers: &[String]) -> Schema { | ||
| let fields: Vec<Field> = headers |
| } | ||
|
|
||
| /// The column line. Streaming writers call this once, before the first batch. | ||
| pub fn write_tsv_header<W: Write>(writer: &mut W, headers: &[String]) -> std::io::Result<()> { |
| sort_chromosomes(counts) | ||
| } | ||
|
|
||
| /// Sort chromosome keys in natural order: 1-22, X, Y, M/MT, then others alphabetically. |
Comment on lines
795
to
801
| println!(); | ||
|
|
||
| // The text file's own name plus .parquet, so both output formats read | ||
| // X_reformatted.<tsv|maf>.parquet. --parquet and --compress are mutually | ||
| // exclusive (checked at startup), so there is no .gz case. | ||
| // X_reformatted.<tsv|maf>.parquet (a -c .gz suffix is dropped first). | ||
| #[cfg(feature = "parquet_out")] | ||
| if let Some(sink) = parquet_sink.take() { | ||
| match sink.close() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes #6.
@tetedange13 asked for either a parquet-only mode or for
-cto work with--parquet. This ships both.--parquet -cis now accepted: the text file is gzipped, the parquet keeps its un-gzipped name (X_reformatted.tsv.gz+X_reformatted.tsv.parquet).--parquet-only: implies--parquet, writes no text file at all. Rejects-c(nothing to compress).--parquet,--parquet-onlyand--parquet -con a real VEP file.validate_release.shonmainstill pointed at the pre-renamedata/paths; fixed.tests/test.rssplit intotests/{annotations,cli,maf,parquet,reports,tsv}.rs+tests/common/mod.rs.