Repository navigation
Align Benin holidays with Laws 90-019 and 2024-32 - #1556
Merged
Merged
Conversation
Remove 26 October, 30 November, 26 December and Easter Sunday, which Law 90-019 does not list. 1 August now uses NATIONAL_DAY, whose French label "Fête Nationale" is the legal name of the day. Model the Vodoun Festival with a new VODOUN_FESTIVAL key: 10 January from 1998 to 2024 (Law 97-031), then the second Friday of January and the Thursday before it from 2025 (Law 2024-32, art. 3). Add the National Days of Law 90-019, art. 3 as observances: 16 January, 28 February with a new PEOPLES_SOVEREIGNTY_DAY key, and 8 March.
Contributor
|
Hey @egbavou, I just found one small "issue": |
Law 90-019 of 1990 created the three National Days (16 January, 28 February and 8 March), so they no longer apply before 1990.
Contributor
Author
|
Thanks @derTobsch, good catch! I added |
derTobsch
reviewed
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benin's holidays did not match the laws that define them. This PR fixes the dates and adds the legal sources.
Changes
NATIONAL_DAY, whose French label "Fête Nationale" is the legal name of the day, instead ofINDEPENDENCE_DAY.VODOUN_FESTIVALkey instead of the sharedTRADITIONAL_DAY:REMEMBRANCE;PEOPLES_SOVEREIGNTY_DAYkey. The law says "Journée de la Souveraineté du Peuple", which is not the "souveraineté nationale" ofNATIONAL_SOVEREIGNTY_DAY;WOMENS_DAY.HolidayBJTestnow covers:The Benin public holidays now follow the same rules as the date-holidays npm package (commenthol/date-holidays#685) and the Nager.Date PR nager/Nager.Date#1175.
Sources