Skip to content

Align Benin holidays with Laws 90-019 and 2024-32 - #1556

Merged
derTobsch merged 3 commits into
focus-shift:mainfrom
egbavou:fix/benin-holidays
Oct 30, 2026
Merged

derTobsch merged 3 commits into
focus-shift:mainfrom
egbavou:fix/benin-holidays

Conversation

@egbavou

@egbavou egbavou commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Benin's holidays did not match the laws that define them. This PR fixes the dates and adds the legal sources.

Changes

  • Removed:
    • 26 October (Armed Forces Day) and 30 November (National Day): Law 90-019 does not list them;
    • 26 December: it has never been a holiday in Benin;
    • Easter Sunday: Law 90-019 lists only Easter Monday.
  • 1 August now uses NATIONAL_DAY, whose French label "Fête Nationale" is the legal name of the day, instead of INDEPENDENCE_DAY.
  • Vodoun Festival, with a new VODOUN_FESTIVAL key instead of the shared TRADITIONAL_DAY:
    • 10 January from 1998 to 2024 (Law 97-031);
    • from 2025, the second Friday of January and the Thursday before it (Law 2024-32, art. 3). This matches the days off declared by the government: 9–10 January 2025 and 8–9 January 2026;
    • no festival before 1998.
  • National Days (Law 90-019, art. 3) added as observances, since they are working days:
    • 16 January, REMEMBRANCE;
    • 28 February, new PEOPLES_SOVEREIGNTY_DAY key. The law says "Journée de la Souveraineté du Peuple", which is not the "souveraineté nationale" of NATIONAL_SOVEREIGNTY_DAY;
    • 8 March, WOMENS_DAY.
  • New keys are translated in all 8 description files.
  • Islamic holidays are unchanged.
  • Holidays before 1990 are still not modelled, as before.
  • Tests: HolidayBJTest now covers:
    • the legal holidays and the observances;
    • the festival days in 1997, 1998, 2024, 2025, 2026 and 2027;
    • the removed days.

The Benin public holidays now follow the same rules as the date-holidays npm package (commenthol/date-holidays#685) and the Nager.Date PR nager/Nager.Date#1175.

Sources

Remove 26 October, 30 November, 26 December and Easter Sunday, which
Law 90-019 does not list. 1 August now uses NATIONAL_DAY, whose French
label "Fête Nationale" is the legal name of the day.

Model the Vodoun Festival with a new VODOUN_FESTIVAL key: 10 January
from 1998 to 2024 (Law 97-031), then the second Friday of January and
the Thursday before it from 2025 (Law 2024-32, art. 3).

Add the National Days of Law 90-019, art. 3 as observances: 16 January,
28 February with a new PEOPLES_SOVEREIGNTY_DAY key, and 8 March.
@derTobsch

Copy link
Copy Markdown
Contributor

Hey @egbavou,
thanks for your time and effort!

I just found one small "issue":
The three observances (16 Jan, 28 Feb, 8 Mar) currently apply from 1900. They were created by Law 90-019, and 16 Jan and 28 Feb mark events from 1977 and 1990. Could you add validFrom="1990" to them and adjust the test?

Law 90-019 of 1990 created the three National Days (16 January,
28 February and 8 March), so they no longer apply before 1990.
@egbavou

egbavou commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @derTobsch, good catch! I added validFrom="1990" to the three observances and adjusted the test: they are now checked as absent until 1989 and present from 1990.

@derTobsch
derTobsch merged commit e2cd682 into focus-shift:main Oct 30, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants