Skip to content

fix: memory leak in pre-processor dollar var increment - #720

Merged
jodavies merged 1 commit into
form-dev:masterfrom
jodavies:dollar-pre-incr
Oct 7, 2025
Merged

jodavies merged 1 commit into
form-dev:masterfrom
jodavies:dollar-pre-incr

Conversation

@jodavies

@jodavies jodavies commented Oct 1, 2025

Copy link
Copy Markdown
Collaborator

This memory is allocated in WriteDollarToBuffer as "DollarOutBuffer" and then stored in stream->buffer by OpenStream. We must free it in CloseStream in the PRERAISEAFTER/PRELOWERAFTER case.

This closes #666 .

This memory is allocated in WriteDollarToBuffer as "DollarOutBuffer"
and then stored in stream->buffer by OpenStream. We must free it
in CloseStream in the PRERAISEAFTER/PRELOWERAFTER case.
@jodavies

jodavies commented Oct 1, 2025

Copy link
Copy Markdown
Collaborator Author

Once this is in, I can add "minceex" based tests to check/extra.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 54.421% (+0.04%) from 54.381%
when pulling c41ebc7 on jodavies:dollar-pre-incr
into 7fa4cef on form-dev:master.

@jodavies
jodavies merged commit 5cc9cfd into form-dev:master Oct 7, 2025
108 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pre-processor dollar increment leaks memory

2 participants