Repository navigation
perf: improve TFORM CopySpectator performance - #905
Merged
Merged
Conversation
CopySpectator creates a one-term prototype expression in the scratch file. We must not use this to determine TFORM bucket size, or the master will create an enormous number of single-term buckets for the workers. Additionally, now that we properly enter the bucket-filling loop, we need to call GetFromSpectator instead of GetTermP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small change to how spectator terms are distributed to TFORM workers. Previously, we ended up creating a huge number of single-term buckets, spoiling efficiency. This now fills the buckets properly.
For a simple benchmark:
on my usual benchmark machine, with
tform -w12, the runtime drops from32.676 s ± 1.053 sto13.639 s ± 0.423 s.The
form-benchtests which use spectators don't see any significant improvement.The (non-public) forcer-based benchmark from Andreas also sees essentially no change (tentative 1%?)